<html><head><meta name="color-scheme" content="light dark"></head><body><pre style="word-wrap: break-word; white-space: pre-wrap;">From 40350ce3ae8701146aafd79c5f7b5582d9955e58 Mon Sep 17 00:00:00 2001
From: Daniel Golle &lt;daniel@makrotopia.org&gt;
Date: Sun, 25 Sep 2022 15:12:35 +0100
Subject: [PATCH 1/2] net: ethernet: mtk_eth_soc: fix wrong use of new helper
 function
To: linux-mediatek@lists.infradead.org,
    netdev@vger.kernel.org,
    Lorenzo Bianconi &lt;lorenzo@kernel.org&gt;
Cc: Sujuan Chen &lt;sujuan.chen@mediatek.com&gt;,
    Bo Jiao &lt;Bo.Jiao@mediatek.com&gt;,
    Felix Fietkau &lt;nbd@nbd.name&gt;,
    John Crispin &lt;john@phrozen.org&gt;,
    Sean Wang &lt;sean.wang@mediatek.com&gt;,
    Mark Lee &lt;Mark-MC.Lee@mediatek.com&gt;,
    David S. Miller &lt;davem@davemloft.net&gt;,
    Eric Dumazet &lt;edumazet@google.com&gt;,
    Jakub Kicinski &lt;kuba@kernel.org&gt;,
    Paolo Abeni &lt;pabeni@redhat.com&gt;,
    Matthias Brugger &lt;matthias.bgg@gmail.com&gt;,
    Chen Minqiang &lt;ptpt52@gmail.com&gt;

In function mtk_foe_entry_set_vlan() the call to field accessor macro
FIELD_GET(MTK_FOE_IB1_BIND_VLAN_LAYER, entry-&gt;ib1)
has been wrongly replaced by
mtk_prep_ib1_vlan_layer(eth, entry-&gt;ib1)

Use correct helper function mtk_get_ib1_vlan_layer instead.

Reported-by: Chen Minqiang &lt;ptpt52@gmail.com&gt;
Fixes: 03a3180e5c09e1 ("net: ethernet: mtk_eth_soc: introduce flow offloading support for mt7986")
Signed-off-by: Daniel Golle &lt;daniel@makrotopia.org&gt;
---
 drivers/net/ethernet/mediatek/mtk_ppe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/ethernet/mediatek/mtk_ppe.c
+++ b/drivers/net/ethernet/mediatek/mtk_ppe.c
@@ -337,7 +337,7 @@ int mtk_foe_entry_set_vlan(struct mtk_et
 {
 	struct mtk_foe_mac_info *l2 = mtk_foe_entry_l2(eth, entry);
 
-	switch (mtk_prep_ib1_vlan_layer(eth, entry-&gt;ib1)) {
+	switch (mtk_get_ib1_vlan_layer(eth, entry-&gt;ib1)) {
 	case 0:
 		entry-&gt;ib1 |= mtk_get_ib1_vlan_tag_mask(eth) |
 			      mtk_prep_ib1_vlan_layer(eth, 1);
</pre></body></html>