<html><head><meta name="color-scheme" content="light dark"></head><body><pre style="word-wrap: break-word; white-space: pre-wrap;">From: Lorenzo Bianconi &lt;lorenzo@kernel.org&gt;
Date: Thu, 12 Jan 2023 10:21:29 +0100
Subject: [PATCH] net: ethernet: mtk_wed: get rid of queue lock for tx queue

Similar to MTK Wireless Ethernet Dispatcher (WED) MCU rx queue,
we do not need to protect WED MCU tx queue with a spin lock since
the tx queue is accessed in the two following routines:
- mtk_wed_wo_queue_tx_skb():
  it is run at initialization and during mt7915 normal operation.
  Moreover MCU messages are serialized through MCU mutex.
- mtk_wed_wo_queue_tx_clean():
  it runs just at mt7915 driver module unload when no more messages
  are sent to the MCU.

Remove tx queue spinlock.

Signed-off-by: Lorenzo Bianconi &lt;lorenzo@kernel.org&gt;
Link: https://lore.kernel.org/r/7bd0337b2a13ab1a63673b7c03fd35206b3b284e.1673515140.git.lorenzo@kernel.org
Signed-off-by: Jakub Kicinski &lt;kuba@kernel.org&gt;
---

--- a/drivers/net/ethernet/mediatek/mtk_wed_wo.c
+++ b/drivers/net/ethernet/mediatek/mtk_wed_wo.c
@@ -258,7 +258,6 @@ mtk_wed_wo_queue_alloc(struct mtk_wed_wo
 		       int n_desc, int buf_size, int index,
 		       struct mtk_wed_wo_queue_regs *regs)
 {
-	spin_lock_init(&amp;q-&gt;lock);
 	q-&gt;regs = *regs;
 	q-&gt;n_desc = n_desc;
 	q-&gt;buf_size = buf_size;
@@ -290,7 +289,6 @@ mtk_wed_wo_queue_tx_clean(struct mtk_wed
 	struct page *page;
 	int i;
 
-	spin_lock_bh(&amp;q-&gt;lock);
 	for (i = 0; i &lt; q-&gt;n_desc; i++) {
 		struct mtk_wed_wo_queue_entry *entry = &amp;q-&gt;entry[i];
 
@@ -299,7 +297,6 @@ mtk_wed_wo_queue_tx_clean(struct mtk_wed
 		skb_free_frag(entry-&gt;buf);
 		entry-&gt;buf = NULL;
 	}
-	spin_unlock_bh(&amp;q-&gt;lock);
 
 	if (!q-&gt;cache.va)
 		return;
@@ -347,8 +344,6 @@ int mtk_wed_wo_queue_tx_skb(struct mtk_w
 	int ret = 0, index;
 	u32 ctrl;
 
-	spin_lock_bh(&amp;q-&gt;lock);
-
 	q-&gt;tail = mtk_wed_mmio_r32(wo, q-&gt;regs.dma_idx);
 	index = (q-&gt;head + 1) % q-&gt;n_desc;
 	if (q-&gt;tail == index) {
@@ -379,8 +374,6 @@ int mtk_wed_wo_queue_tx_skb(struct mtk_w
 	mtk_wed_wo_queue_kick(wo, q, q-&gt;head);
 	mtk_wed_wo_kickout(wo);
 out:
-	spin_unlock_bh(&amp;q-&gt;lock);
-
 	dev_kfree_skb(skb);
 
 	return ret;
--- a/drivers/net/ethernet/mediatek/mtk_wed_wo.h
+++ b/drivers/net/ethernet/mediatek/mtk_wed_wo.h
@@ -211,7 +211,6 @@ struct mtk_wed_wo_queue {
 	struct mtk_wed_wo_queue_regs regs;
 
 	struct page_frag_cache cache;
-	spinlock_t lock;
 
 	struct mtk_wed_wo_queue_desc *desc;
 	dma_addr_t desc_dma;
</pre></body></html>